From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Yang,Wei" <Wei.Yang@windriver.com>
Cc: mroberto@cpti.cetuc.puc-rio.br, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock
Date: Wed, 2 Jul 2014 11:19:26 +0100 [thread overview]
Message-ID: <20140702101925.GE32514@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <53B3CEAC.9080609@windriver.com>
On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote:
> Hi Guys,
>
> What about this patch?
The only concern on the face of it is that it removes mutual exclusion
from the pci config write path, where a read-modifiy-write operation is
performed.
However, the PCI code already gives that guarantee (drivers/pci/access.c)
so this should be safe.
As this is fairly old code, it would be useful to know what the motivation
is behind this change. Is it purely clean up, or is it something that
you've tested, or is this a change that you require for something else?
Thanks.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-07-02 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 7:41 Wei.Yang
2014-07-02 9:19 ` Yang,Wei
2014-07-02 10:19 ` Russell King - ARM Linux [this message]
2014-07-02 11:02 ` Yang,Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702101925.GE32514@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Wei.Yang@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroberto@cpti.cetuc.puc-rio.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®