From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
Vincent Palatin <vpalatin@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Randall Spangler <rspangler@chromium.org>,
sjg@chromium.org, afaerber@suse.de, stephan@synkhronix.com,
olof@lixom.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regmap: cache: regcache_hw_init() should use regmap_bulk_read()
Date: Thu, 3 Jul 2014 15:55:17 +0100 [thread overview]
Message-ID: <20140703145517.GE410@sirena.org.uk> (raw)
In-Reply-To: <1403898973-19571-2-git-send-email-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Fri, Jun 27, 2014 at 12:56:11PM -0700, Doug Anderson wrote:
> We really should be using regmap_bulk_read() in regcache_hw_init().
> The regmap_bulk_read() will translate into regmap_raw_read() when
> appropriate. Doing this fixes problems where regmap_smbus() will
> crash because they don't implement .read and .write.
Not quite - _bulk_read() does do byte swapping so...
> - ret = regmap_raw_read(map, 0, tmp_buf,
> + ret = regmap_bulk_read(map, 0, tmp_buf,
> map->num_reg_defaults_raw);
> map->cache_bypass = cache_bypass;
> if (ret < 0) {
...a direct replacement shouldn't quite work. We need an actual
fallback to word at a time operation I think.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-03 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 19:56 [PATCH 0/3] Add support for limited i2c tunnel for exynos5250-spring Doug Anderson
2014-06-27 19:56 ` [PATCH 1/3] regmap: cache: regcache_hw_init() should use regmap_bulk_read() Doug Anderson
2014-07-03 14:55 ` Mark Brown [this message]
2014-06-27 19:56 ` [PATCH 2/3] mfd: cros_ec: Use the proper size when looking at the cros_ec_i2c result Doug Anderson
2014-06-30 19:36 ` Simon Glass
2014-07-02 7:23 ` Lee Jones
2014-07-02 15:51 ` Doug Anderson
2014-07-03 6:38 ` Lee Jones
2014-06-27 19:56 ` [PATCH 3/3] i2c: cros_ec: Support a limited i2c tunnel for exynos5250-spring Doug Anderson
2014-06-27 21:44 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703145517.GE410@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afaerber@suse.de \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rspangler@chromium.org \
--cc=sjg@chromium.org \
--cc=stephan@synkhronix.com \
--cc=vpalatin@chromium.org \
--cc=wfrichar@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome