From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-wireless@vger.kernel.org, linux-nfc@ml01.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-nfc] [PATCH] NFC: trf7970a: Move trf7970a_init inside #ifdef CONFIG_PM_RUNTIME
Date: Thu, 3 Jul 2014 13:57:40 -0700 [thread overview]
Message-ID: <20140703205740.GA19951@animalcreek.com> (raw)
In-Reply-To: <20140616155855.GA2539@animalcreek.com>
On Mon, Jun 16, 2014 at 08:58:55AM -0700, Mark A. Greer wrote:
> On Mon, Jun 16, 2014 at 03:06:13PM +0200, Geert Uytterhoeven wrote:
> > If CONFIG_PM_RUNTIME=n:
> >
> > drivers/nfc/trf7970a.c:755: warning: ‘trf7970a_init’ defined but not used
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Acked-by: Mark A. Greer <mgreer@animalcreek.com>
Actually, I'd like to change my mind on this. I've modified the code
locally and I will have to move trf7970a_init() back to where it originally
was again, if this patch is taken. If you can tolerate the warning for
another week or so, I'll have a new set of patches that will fix it.
Not a big deal if you still want to take it.
Mark
--
prev parent reply other threads:[~2014-07-03 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 13:06 Geert Uytterhoeven
2014-06-16 15:58 ` Mark A. Greer
2014-07-03 20:57 ` Mark A. Greer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703205740.GA19951@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@ml01.01.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®