From: Borislav Petkov <bp@alien8.de>
To: Jason Baron <jbaron@akamai.com>
Cc: m.chehab@samsung.com, tony.luck@intel.com, hpa@zytor.com,
mingo@kernel.org, dougthompson@xmission.com,
mitake@dcl.info.waseda.ac.jp, aris@redhat.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q
Date: Fri, 4 Jul 2014 16:07:55 +0200 [thread overview]
Message-ID: <20140704140755.GA3340@pd.tnic> (raw)
In-Reply-To: <281f09da7ad01e5cea99737ec34d2399bdbbbf63.1403818526.git.jbaron@akamai.com>
On Thu, Jun 26, 2014 at 09:58:28PM +0000, Jason Baron wrote:
> Even on x86-64, I've found the need to break up a readq() into 2 readl()
> calls. According to the Intel datasheet for the E3-1200 processor:
>
> "
> Software must not access B0/D0/F0 32-bit memory-mapped registers with
> requests that cross a DW boundary.
> "
>
> (http://www.intel.com/content/www/us/en/processors/xeon/xeon-e3-1200-family-vol-2-datasheet.html p. 16)
>
> I can confirm this is true via several hard machine lockups.
>
> Thus, add explicit hi_lo_[readq|write]_q and lo_hi_[read|write]_q so that these
> uses are spelled out.
>
> Signed-off-by: Jason Baron <jbaron@akamai.com>
Applied, thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-07-04 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 21:58 [PATCH v2 0/3] Introduce ie31200_edac driver Jason Baron
2014-06-26 21:58 ` [PATCH v2 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q Jason Baron
2014-07-04 14:07 ` Borislav Petkov [this message]
2014-06-26 21:58 ` [PATCH v2 2/3] x38_edac: make use of lo_hi_readq() Jason Baron
2014-07-04 14:08 ` Borislav Petkov
2014-06-26 21:58 ` [PATCH v2 3/3] ie31200_edac: Introduce the driver Jason Baron
2014-07-04 14:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140704140755.GA3340@pd.tnic \
--to=bp@alien8.de \
--cc=aris@redhat.com \
--cc=dougthompson@xmission.com \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mingo@kernel.org \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome