mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	"andriy.shevchenko@intel.com" <andriy.shevchenko@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"zhuzhenhua@allwinnertech.com" <zhuzhenhua@allwinnertech.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
	"kevin.z.m.zh@gmail.com" <kevin.z.m.zh@gmail.com>,
	"sunny@allwinnertech.com" <sunny@allwinnertech.com>,
	"shuge@allwinnertech.com" <shuge@allwinnertech.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v10 2/2] dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller
Date: Sun, 6 Jul 2014 17:22:00 +0200	[thread overview]
Message-ID: <201407061722.01279.arnd@arndb.de> (raw)
In-Reply-To: <20140704075710.GN31996@lukather>

On Friday 04 July 2014, Maxime Ripard wrote:
> > > > It feels a little fragile to rely on the organisation of the clock tree
> > > > and the naming thereof. If the IP block is ever reused on an SoC with a
> > > > different clock tree layout then we have to handle things differently.
> > > 
> > > What do you suggest then?
> > 
> > I will admit that I don't have a better suggestion.
> > 
> > Without knowing which particular constraint on the mux parent clock we
> > care about it's difficult to suggest anything useful.
> 
> Well, I first made it into the mach- directory, and then was told to
> move it in the driver itself, so we're kind of running out of options
> :)

How about having a property in the clock provider node that forces a
specific value for the mux? I think that's generally the preferred solution
for any clock settings that go beyond what an OS can be expected to figure
out for itself.

	Arnd

  reply	other threads:[~2014-07-07  9:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 13:20 [PATCH v10 0/2] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-06-30 13:20 ` [PATCH v10 1/2] Documentation: dt: Add Allwinner A31 DMA controller bindings Maxime Ripard
2014-06-30 13:20 ` [PATCH v10 2/2] dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-06-30 14:20   ` Mark Rutland
2014-06-30 15:19     ` Maxime Ripard
2014-06-30 15:33       ` Mark Rutland
2014-07-01  7:21         ` Maxime Ripard
2014-07-01 12:48           ` Mark Rutland
2014-07-04  7:57             ` Maxime Ripard
2014-07-06 15:22               ` Arnd Bergmann [this message]
2014-07-07 12:41                 ` Maxime Ripard
2014-07-27 18:49             ` Mark Brown
2014-07-28 15:09               ` Maxime Ripard
2014-07-29 12:05                 ` Mark Brown
2014-07-06  3:23   ` [linux-sunxi] " Emilio López

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201407061722.01279.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kevin.z.m.zh@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=shuge@allwinnertech.com \
    --cc=sunny@allwinnertech.com \
    --cc=vinod.koul@intel.com \
    --cc=zhuzhenhua@allwinnertech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome