From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Josh Triplett <josh@joshtriplett.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: Add ability to insert and delete lines to patch/file
Date: Tue, 8 Jul 2014 14:07:58 -0700 [thread overview]
Message-ID: <20140708140758.cc0bcd1d7af956afde149815@linux-foundation.org> (raw)
In-Reply-To: <1404853064.932.49.camel@joe-AO725>
On Tue, 08 Jul 2014 13:57:44 -0700 Joe Perches <joe@perches.com> wrote:
> On Tue, 2014-07-08 at 13:24 -0700, Andrew Morton wrote:
> > On Tue, 8 Jul 2014 10:53:36 -0700 Joe Perches <joe@perches.com> wrote:
> >
> > > This can be valuable to insert or delete blank lines as well
> > > as fix misplaced brace or else uses.
> >
> > hm, do we really want to go down this path?
>
> Maybe, maybe not.
>
> I've seen a lot of patches that people seem to spend
> time producing (frequently incorrectly done too) that
> could be better automated.
>
> > It's a very long one and it leads to /usr/bin/indent?
>
> For now, I think it's a pretty minimal bit of code.
No strong opinions here.
> I've suggested Lindent be removed from the tree.
> https://lkml.org/lkml/2013/2/11/390
Maybe it's fixable, dunno - I don't recall ever seeing anyone get down
and poke at it. Of course, indent itself is open source...
next prev parent reply other threads:[~2014-07-08 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 17:53 [PATCH 0/2] checkpatch: Add ability to insert/delete lines Joe Perches
2014-07-08 17:53 ` [PATCH 1/2] checkpatch: Add an index variable for fixed lines Joe Perches
2014-07-08 17:53 ` [PATCH 2/2] checkpatch: Add ability to insert and delete lines to patch/file Joe Perches
2014-07-08 20:24 ` Andrew Morton
2014-07-08 20:57 ` Joe Perches
2014-07-08 21:07 ` Andrew Morton [this message]
2014-07-08 21:24 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708140758.cc0bcd1d7af956afde149815@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®