From: Greg KH <gregkh@linuxfoundation.org>
To: sanjeev sharma <sanjeevsharmaengg@gmail.com>
Cc: devel@driverdev.osuosl.org, peter.senna@gmail.com,
linux-kernel@vger.kernel.org, rmfrfs@gmail.com,
teobaluta@gmail.com, Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Subject: Re: [PATCH v4 4/4] staging: rtl8192u: Fixed too long line
Date: Thu, 10 Jul 2014 15:16:06 -0700 [thread overview]
Message-ID: <20140710221606.GB26493@kroah.com> (raw)
In-Reply-To: <1404995097-12689-5-git-send-email-sanjeevsharmaengg@gmail.com>
On Thu, Jul 10, 2014 at 05:54:57PM +0530, sanjeev sharma wrote:
> From: sanjeev sharma <sanjeev_sharma@mentor.com>
>
> This patch will fix too long lines warning
> reported by checkpatch.pl.
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
> drivers/staging/rtl8192u/r819xU_phy.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
> index 3155616..b2d81e9 100644
> --- a/drivers/staging/rtl8192u/r819xU_phy.c
> +++ b/drivers/staging/rtl8192u/r819xU_phy.c
> @@ -1236,7 +1236,8 @@ static u8 rtl8192_phy_SetSwChnlCmdArray(SwChnlCmd *CmdTable, u32 CmdTableIdx,
> return false;
> }
> if (CmdTableIdx >= CmdTableSz) {
> - RT_TRACE(COMP_ERR, "%s(): Access invalid index, please check size of the table, CmdTableIdx:%d, CmdTableSz:%d\n",
> + RT_TRACE(COMP_ERR,
> + "%s():invalid index,CmdTableIdx:%d, CmdTableSz:%d\n",
Why did you change the string? That's not ok, you can ignore this
warning, it's a string that you can not break up, or change.
thanks,
greg k-h
prev parent reply other threads:[~2014-07-10 22:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 6:04 [PATCH] staging: rtl8192u: fix checkpatch error/warning in r819xU_phy.c sanjeev sharma
2014-07-08 7:43 ` Dan Carpenter
[not found] ` <CAGUYZuQgpNQRRg5X_AYv_iW5W60EdEwo0VOe3EJAPJocKrTf3g@mail.gmail.com>
2014-07-08 10:01 ` Dan Carpenter
2014-07-09 6:04 ` [PATCH v2 0/4] Fix checkpatch reported problem " sanjeev sharma
2014-07-09 6:04 ` [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement " sanjeev sharma
2014-07-09 8:09 ` Dan Carpenter
2014-07-09 10:14 ` Sharma, Sanjeev
2014-07-09 6:04 ` [PATCH v2 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning " sanjeev sharma
2014-07-09 6:04 ` [PATCH v2 3/4] staging: rtl8192u: Fixed switch and case indentation error " sanjeev sharma
2014-07-09 6:04 ` [PATCH v2 4/4] staging: rtl8192u: Fixed too long lines " sanjeev sharma
2014-07-09 12:19 ` [PATCH v3 0/4] line wrapping of changelog sanjeev sharma
2014-07-09 12:15 ` Dan Carpenter
2014-07-09 12:19 ` [PATCH v3 1/4] staging: rtl8192u: Remove useless return statements sanjeev sharma
2014-07-09 19:24 ` Greg KH
2014-07-10 12:19 ` Sharma, Sanjeev
2014-07-09 12:19 ` [PATCH v3 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning sanjeev sharma
2014-07-09 12:19 ` [PATCH v3 3/4] staging: rtl8192u: Fixed switch and case indentation error sanjeev sharma
2014-07-09 12:19 ` [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines sanjeev sharma
2014-07-09 12:56 ` Joe Perches
2014-07-10 12:18 ` Sharma, Sanjeev
2014-07-10 12:24 ` [PATCH v4 0/4] staging: rtl8192u: checkpatch fixes sanjeev sharma
2014-07-10 12:24 ` [PATCH v4 1/4] staging: rtl8192u: Remove useless return statement sanjeev sharma
2014-07-10 12:24 ` [PATCH v4 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning sanjeev sharma
2014-07-10 22:15 ` Greg KH
2014-07-10 12:24 ` [PATCH v4 3/4] staging: rtl8192u: Fixed switch and case indentation error sanjeev sharma
2014-07-10 12:24 ` [PATCH v4 4/4] staging: rtl8192u: Fixed too long line sanjeev sharma
2014-07-10 22:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710221606.GB26493@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Sanjeev_Sharma@mentor.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=sanjeevsharmaengg@gmail.com \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®