From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>,
Stephen Warren <swarren@nvidia.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
linux-serial@vger.kernel.org, yrl.pp-manager.tt@hitachi.com,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Aaron Sierra <asierra@xes-inc.com>, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH V8 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers
Date: Thu, 10 Jul 2014 16:16:37 -0700 [thread overview]
Message-ID: <20140710231637.GB9423@kroah.com> (raw)
In-Reply-To: <20140710153157.57902972@alan.etchedpixels.co.uk>
On Thu, Jul 10, 2014 at 03:31:57PM +0100, One Thousand Gnomes wrote:
> > I really don't like the way that the tty core has been changed to handle
> > multiple attribute groups, as I feel tty drivers shouldn't be creating
> > "special" sysfs files, depending on what driver is bound to them.
>
> The intent isn't that it is "special" but that it can be propogated to
> others as and when they wish to provide it.
>
> > Usually we have handled this using tools like 'stty' and ioctls, right?
> > Surely there is an ioctl to control the interrupt level, right? Hasn't
> > this been covered before somehow?
>
> No, and the direction when this started was to use sysfs as we have also
> been moving all the other attributes towards sysfs and has been since
> 2012.
>
> TTY devices do have lots of strange attributes and right now many of them
> are only programmable by using device tree and rebooting.
Ok. Hm, there has to be a better way to do the group sysfs file
handling...
Let me work on this tomorrow and see what I can come up with. We should
be able to use the is_visable() attribute to create/notcreate the
attribute where needed...
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-10 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 6:16 [PATCH V8 0/2] serial/uart/8250: Introduce tunable RX trigger I/F Yoshihiro YUNOMAE
2014-05-30 6:16 ` [PATCH V8 1/2] serial/uart: Introduce device specific attribute group to uart_port structure Yoshihiro YUNOMAE
2014-05-30 6:16 ` [PATCH V8 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers Yoshihiro YUNOMAE
2014-07-10 0:28 ` Greg Kroah-Hartman
2014-07-10 14:31 ` One Thousand Gnomes
2014-07-10 23:16 ` Greg Kroah-Hartman [this message]
2014-07-12 21:22 ` Greg KH
2014-07-14 2:19 ` Yoshihiro YUNOMAE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710231637.GB9423@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=asierra@xes-inc.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=heikki.krogerus@linux.intel.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=jg1.han@samsung.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=swarren@nvidia.com \
--cc=yoshihiro.yunomae.ez@hitachi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®