Re: [tip:sched/core] sched/numa: Use effective_load() to balance NUMA loads

[Peter Zijlstra <peterz@infradead.org>]

On Wed, Jul 09, 2014 at 12:02:03PM -0400, Rik van Riel wrote:
> On 07/05/2014 06:44 AM, tip-bot for Rik van Riel wrote:
> > Commit-ID:  6dc1a672ab15604947361dcd02e459effa09bad5
> > Gitweb:     http://git.kernel.org/tip/6dc1a672ab15604947361dcd02e459effa09bad5
> > Author:     Rik van Riel <riel@redhat.com>
> > AuthorDate: Mon, 23 Jun 2014 11:46:14 -0400
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Sat, 5 Jul 2014 11:17:35 +0200
> > 
> > sched/numa: Use effective_load() to balance NUMA loads
> > 
> > When CONFIG_FAIR_GROUP_SCHED is enabled, the load that a task places
> > on a CPU is determined by the group the task is in. The active groups
> > on the source and destination CPU can be different, resulting in a
> > different load contribution by the same task at its source and at its
> > destination. As a result, the load needs to be calculated separately
> > for each CPU, instead of estimated once with task_h_load().
> > 
> > Getting this calculation right allows some workloads to converge,
> > where previously the last thread could get stuck on another node,
> > without being able to migrate to its final destination.
> 
> Self-NAK
> 
> This patch should be reverted.
> 
> It turns out that the tree I am working on was missing
> changeset a003a25b227d59ded9197ced109517f037d01c27,
> which makes weighted_cpuload and update_numa_stats use
> p->se.avg.load_avg_contrib instead of p->se.load.weight.
> 
> This means using effective_load, which operates on the
> load.weight is inappropriate.
> 
> Sorry for the noise.

n/p I'll take it out. Thanks!