Re: [PATCH char-misc-next v3 2/8] misc: mic: add a bus driver for virtual MIC devices

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Jul 11, 2014 at 11:49:56PM -0700, Sudeep Dutt wrote:
> On Fri, 2014-07-11 at 18:31 -0700, Greg Kroah-Hartman wrote:
> > On Fri, Jul 11, 2014 at 06:27:20PM -0700, Greg Kroah-Hartman wrote:
> > > On Fri, Jul 11, 2014 at 02:04:20PM -0700, Sudeep Dutt wrote:
> > > > This MIC virtual bus driver takes the responsibility of creating all
> > > > the virtual devices connected to the PCIe device on the host and the
> > > > platform device on the card. The MIC bus hardware operations provide
> > > > a way to abstract certain hardware details from the base physical devices.
> > > > Examples of devices added on the MIC virtual bus include host DMA and card DMA.
> > > > This abstraction enables using a common DMA driver on host and card.
> > > > 
> > > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > > Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
> > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
> > > > Signed-off-by: Siva Yerramreddy <yshivakrishna@gmail.com>
> > > > ---
> > > >  drivers/misc/mic/Kconfig       |  17 ++++
> > > >  drivers/misc/mic/Makefile      |   1 +
> > > >  drivers/misc/mic/bus/Makefile  |   5 +
> > > >  drivers/misc/mic/bus/mic_bus.c | 218 +++++++++++++++++++++++++++++++++++++++++
> > > >  include/linux/mic_bus.h        | 110 +++++++++++++++++++++
> > > >  5 files changed, 351 insertions(+)
> > > >  create mode 100644 drivers/misc/mic/bus/Makefile
> > > >  create mode 100644 drivers/misc/mic/bus/mic_bus.c
> > > >  create mode 100644 include/linux/mic_bus.h
> > > 
> > > Looks good, but no addition to scripts/mod/file2alias.c to allow
> > > autoloading of mic_bus drivers?
> > > 
> > > I'll take patches 1 and 2 here, as I need some acks from the DMA people
> > > on patch 3.
> > 
> > And I took 4-8 as well, as they seemed independant from patch 3.
> > 
> 
> Thanks for accepting the patches Greg. The good news is that the 7
> patches accepted build fine without patch 3 and the drivers load
> successfully.
> 
> The bad news is that the MIC Coprocessors no longer boot without patch 3
> since the host driver does not find any DMA channels. Reverting patch 5
> titled "add dma support in host driver" with SHA d4ef098 allows the
> Coprocessors to boot again but accepting patch 3 instead is the cleanest
> solution here. Dan, please review patch 3 as we would really like it to
> get accepted before the 3.17 merge window opens.

Ah, I didn't realize it would break, sorry.

Ok, I've queued up patch 3 now, it looks self-contained, and I didn't
see anything "obvious" wrong with it.  So if any dma maintainers
objections show up later, we can always just patch the code up.

thanks,

greg k-h