From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbaGMHVg (ORCPT ); Sun, 13 Jul 2014 03:21:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45331 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbaGMHVb (ORCPT ); Sun, 13 Jul 2014 03:21:31 -0400 Date: Sun, 13 Jul 2014 09:21:27 +0200 From: Jean Delvare To: Guenter Roeck Cc: Wolfram Sang , Randy Dunlap , linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: stub: Add support for SMBus block commands Message-ID: <20140713092127.4bedfa18@endymion.delvare> In-Reply-To: <53C14ECD.7050105@roeck-us.net> References: <1404742983-27303-1-git-send-email-linux@roeck-us.net> <20140708215453.0677d3ed@endymion.delvare> <53BC4F15.9030608@roeck-us.net> <20140712112019.618d8a03@endymion.delvare> <53C14ECD.7050105@roeck-us.net> Organization: SUSE Linux X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, On Sat, 12 Jul 2014 08:05:49 -0700, Guenter Roeck wrote: > Any idea how we could inject errors ? Error path testing would be quite useful. Good idea. This should probably be done with a sysfs attribute so that it can be turned on and off as desired. Off by default, of course. Some other subsystems already support error injection, you could check how they are doing it, do that we do not diverge needlessly. Do you think there is any value in failing with different error codes, or just -EIO is enough? Do you think it should fail all the time when error injection is enabled, or is there a value in having only a certain % of commands fail? -- Jean Delvare SUSE L3 Support