From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Olivier Sobrie <olivier@sobrie.be>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
David Laight <David.Laight@ACULAB.COM>,
Dan Williams <dcbw@redhat.com>, Jan Dumon <j.dumon@option.com>
Subject: Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data
Date: Mon, 14 Jul 2014 14:27:34 +0100 [thread overview]
Message-ID: <20140714142734.4b9c0afa@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1405332530-2507-2-git-send-email-olivier@sobrie.be>
On Mon, 14 Jul 2014 12:08:50 +0200
Olivier Sobrie <olivier@sobrie.be> wrote:
> When the module sends bursts of data, sometimes a deadlock happens in
> the hso driver when the tty buffer doesn't get the chance to be flushed
> quickly enough.
>
> Remove the endless while loop in function put_rxbuf_data() which is
> called by the urb completion handler.
> If there isn't enough room in the tty buffer, discards all the data
> received in the URB.
>
> Cc: David Miller <davem@davemloft.net>
> Cc: David Laight <David.Laight@ACULAB.COM>
> Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
> Cc: Dan Williams <dcbw@redhat.com>
> Cc: Jan Dumon <j.dumon@option.com>
> Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
Acked-by: Alan Cox <alan@linux.intel.com>
next prev parent reply other threads:[~2014-07-14 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 10:08 [PATCH v2 1/2] hso: remove unused workqueue Olivier Sobrie
2014-07-14 10:08 ` [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data Olivier Sobrie
2014-07-14 13:27 ` One Thousand Gnomes [this message]
2014-07-15 2:27 ` David Miller
2014-07-15 2:27 ` [PATCH v2 1/2] hso: remove unused workqueue David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-07-07 9:06 [PATCH 2/2] hso: fix deadlock when receiving bursts of data Olivier Sobrie
2014-07-11 13:05 ` [PATCH v2 " Olivier Sobrie
2014-07-11 18:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714142734.4b9c0afa@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier@sobrie.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®