From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] workqueue: remove the first check and the return value of maybe_create_worker()
Date: Mon, 14 Jul 2014 10:40:22 -0400 [thread overview]
Message-ID: <20140714144022.GC31610@htj.dyndns.org> (raw)
In-Reply-To: <53C340B3.5040209@cn.fujitsu.com>
On Mon, Jul 14, 2014 at 10:30:11AM +0800, Lai Jiangshan wrote:
> We already have create_worker(). And maybe_create_worker() does not always create worker.
Well, it does unless it fails. Explicit maybe_ there is quite
misleading.
> maybe_create_worker() may not create worker if the condition is changed after
> it fails at the first time,
It's misleading. Please come up with a different name.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-14 14:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 16:01 [PATCH 0/3] workqueue: manager cleanup Lai Jiangshan
2014-07-10 16:01 ` [PATCH 1/3] workqueue: remove the first check and the return value of maybe_create_worker() Lai Jiangshan
2014-07-11 15:03 ` Tejun Heo
2014-07-14 2:30 ` Lai Jiangshan
2014-07-14 14:40 ` Tejun Heo [this message]
2014-07-10 16:01 ` [PATCH 2/3] workqueue: remove the guarantee and the retrying " Lai Jiangshan
2014-07-11 15:02 ` Tejun Heo
2014-07-10 16:01 ` [PATCH 3/3] workqueue: unfold start_worker() into create_worker() Lai Jiangshan
2014-07-14 4:05 ` [PATCH 0/1 V2] workqueue: manager cleanup Lai Jiangshan
2014-07-14 4:05 ` [PATCH 1/1 V2] workqueue: unfold start_worker() into create_worker() Lai Jiangshan
2014-07-16 1:28 ` Lai Jiangshan
2014-07-18 22:57 ` Tejun Heo
2014-07-22 5:03 ` [PATCH V3] " Lai Jiangshan
2014-07-22 15:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714144022.GC31610@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®