Re: [PATCH 4/4] perf tools: Add --debug optionto set debug variable

[Jiri Olsa <jolsa@redhat.com>]

On Mon, Jul 14, 2014 at 04:51:06PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Sat, 12 Jul 2014 23:56:28 +0200, Jiri Olsa wrote:
> > Adding --debug option as a way to setup debug variables.
> > Starting with support for verbose, more will come.
> >
> > It's possible to use it now with report command:
> >   $ perf report --debug verbose
> >   $ perf report --debug verbose=2
> >
> > I'll need this support to add separated debug variable
> > for ordered events change in order to separate debug
> > output out of standard verbose stream.
> 
> Hmm.. okay.  I think there'll be more users for this.
> 
> 
> >
> > Also removing unneeded getopt.h includes.
> 
> I guess Arnaldo wants to see it as a separate change ;-)

maybe ;-) I hit an issue with this by adding #include "parse-options.h"
into debug.h ... we have a some name clashes with getopt.h

> 
> 
> > +static struct variables_t {
> > +	const char *name;
> > +	int *ptr;
> > +} variables[] = {
> 
> This is a too general name.  How about debug_variable or debug_domain?

debug_variable sounds good to me, will change

thanks,
jirka