From: Mark Brown <broonie@kernel.org>
To: "Murphy, Dan" <dmurphy@ti.com>
Cc: "linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6] ASoC: tas2552: Support TI TAS2552 Amplifier
Date: Mon, 14 Jul 2014 20:17:11 +0100 [thread overview]
Message-ID: <20140714191711.GI6800@sirena.org.uk> (raw)
In-Reply-To: <00FC9A978A94B7418C33AFAE8A35ED49D80B10@DFLE09.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Mon, Jul 14, 2014 at 07:07:06PM +0000, Murphy, Dan wrote:
> On 07/14/2014 01:43 PM, Mark Brown wrote:
> >> +config SND_SOC_TAS2552
> >> + tristate "Texas Instruments TAS2552 Mono Audio amplifier"
> >> + depends on I2C
> >> +
> >> endmenu
> > Keep this and Makefile sorted - since this is a proper CODEC driver it
> > should be in with the CODECs and also sorted in alphabetical order.
> OK. I was trying to stay away from a conflict by adding to the
> bottom of the file.
The whole point is to avoid conflicts - if everyone adds at the bottom
of the file any two adds are pretty much guaranteed to conflict either
on application or on merge. Sorting avoids most of these and makes any
that do occur much clearer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-14 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:44 Dan Murphy
2014-07-14 18:43 ` Mark Brown
2014-07-14 19:07 ` Murphy, Dan
2014-07-14 19:17 ` Mark Brown [this message]
2014-07-14 19:33 ` Murphy, Dan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714191711.GI6800@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®