From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] tracing: change filter_free_subsystem_*() to check ->subsystem rather then ->name
Date: Mon, 14 Jul 2014 21:23:54 +0200 [thread overview]
Message-ID: <20140714192353.GA20882@redhat.com> (raw)
In-Reply-To: <20140714152029.21bd22f6@gandalf.local.home>
On 07/14, Steven Rostedt wrote:
>
> On Fri, 11 Jul 2014 21:06:55 +0200
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > @@ -846,13 +846,10 @@ static void filter_free_subsystem_preds(struct event_subsystem *system,
> > struct trace_array *tr)
> > {
> > struct ftrace_event_file *file;
> > - struct ftrace_event_call *call;
> >
> > list_for_each_entry(file, &tr->events, list) {
> > - call = file->event_call;
> > - if (strcmp(call->class->system, system->name) != 0)
> > + if (file->system->subsystem != system)
>
> This is only used on one place. What about just passing in dir instead
> of system and then do:
I swear, I too thought about this ;) OK, in v2.
Oleg.
next prev parent reply other threads:[~2014-07-14 19:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 19:06 [PATCH 0/7] tracing: instance_rmdir() leaks ftrace_event_file->filter Oleg Nesterov
2014-07-11 19:06 ` [PATCH 1/7] " Oleg Nesterov
2014-07-14 18:35 ` Steven Rostedt
2014-07-14 19:03 ` Oleg Nesterov
2014-07-11 19:06 ` [PATCH 2/7] tracing: kill destroy_preds() and destroy_file_preds() Oleg Nesterov
2014-07-11 19:06 ` [PATCH 3/7] tracing: kill destroy_call_preds() Oleg Nesterov
2014-07-11 19:06 ` [PATCH 4/7] tracing: kill call_filter_disable() Oleg Nesterov
2014-07-14 19:03 ` Steven Rostedt
2014-07-11 19:06 ` [PATCH 5/7] tracing/uprobes: kill the dead TRACE_EVENT_FL_USE_CALL_FILTER logic Oleg Nesterov
2014-07-14 19:04 ` Steven Rostedt
2014-07-15 0:18 ` Srikar Dronamraju
2014-07-11 19:06 ` [PATCH 6/7] tracing: kill ftrace_event_call->files Oleg Nesterov
2014-07-14 19:06 ` Steven Rostedt
2014-07-11 19:06 ` [PATCH 7/7] tracing: change filter_free_subsystem_*() to check ->subsystem rather then ->name Oleg Nesterov
2014-07-14 13:58 ` Namhyung Kim
2014-07-14 16:02 ` Oleg Nesterov
2014-07-14 19:21 ` Steven Rostedt
2014-07-14 19:20 ` Steven Rostedt
2014-07-14 19:23 ` Oleg Nesterov [this message]
2014-07-14 13:54 ` [PATCH 0/7] tracing: instance_rmdir() leaks ftrace_event_file->filter Namhyung Kim
2014-07-14 16:15 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714192353.GA20882@redhat.com \
--to=oleg@redhat.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome