mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonio Ospite <ao2@ao2.it>
To: Jamie Lentin <jm@lentin.co.uk>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] Add support for Lenovo Compact Keyboard
Date: Mon, 14 Jul 2014 23:02:56 +0200	[thread overview]
Message-ID: <20140714230256.9bd2c374a5b7ce085d5064be@ao2.it> (raw)
In-Reply-To: <1405236262-8070-1-git-send-email-jm@lentin.co.uk>

On Sun, 13 Jul 2014 08:24:18 +0100
Jamie Lentin <jm@lentin.co.uk> wrote:

> This patchset follows on from my previous attempts to add support for
> these keyboards from Lenovo.
[...] 

Hi Jamie,

in the next (and last) iteration add some context to the short commit
message, e.g. by adding a prefix:

HID: lenovo: ...

following the scheme of previous commits in the history.

> Cheers,
> 
> Jamie Lentin (4):
>   Rename hid-lenovo-tpkbd to hid-lenovo
>   Make all base functions switch depending on product ID
>   Style fixes
>   Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

Maybe rename Bluetooth to BT if this becomes too long with the prefix.

Thanks,
   Antonio 

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

      parent reply	other threads:[~2014-07-14 21:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-13  7:24 Jamie Lentin
2014-07-13  7:24 ` [PATCH v4 1/4] Rename hid-lenovo-tpkbd to hid-lenovo Jamie Lentin
2014-07-14  9:42   ` Antonio Ospite
2014-07-18  9:35     ` Jamie Lentin
2014-07-21 13:55       ` Antonio Ospite
2014-07-13  7:24 ` [PATCH v4 2/4] Make all base functions switch depending on product ID Jamie Lentin
2014-07-14 10:19   ` Antonio Ospite
2014-07-13  7:24 ` [PATCH v4 3/4] Style fixes Jamie Lentin
2014-07-14 10:19   ` Antonio Ospite
2014-07-13  7:24 ` [PATCH v4 4/4] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint Jamie Lentin
2014-07-14 10:21   ` Antonio Ospite
2014-07-14 21:02 ` Antonio Ospite [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714230256.9bd2c374a5b7ce085d5064be@ao2.it \
    --to=ao2@ao2.it \
    --cc=hdegoede@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=jm@lentin.co.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®