From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757590AbaGOElO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Jul 2014 00:41:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28999 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752465AbaGOElN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Jul 2014 00:41:13 -0400
Date: Tue, 15 Jul 2014 10:10:28 +0530
From: Amit Shah <amit.shah@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org,
        Virtualization List <virtualization@lists.linux-foundation.org>,
        Rusty Russell <rusty@rustcorp.com.au>, keescook@chromium.org,
        jason@lakedaemon.net
Subject: Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes
Message-ID: <20140715044028.GA26186@grmbl.mre>
References: <cover.1404987133.git.amit.shah@redhat.com>
 <20140714125006.GA9958@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140714125006.GA9958@gondor.apana.org.au>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote:
> On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote:
> > v3:
> >  - Kees Cook pointed out a weird side-effect: devices which have
> >    ->init() registered get their randomness added to the system each
> >    time they're switched in, but devices that don't have the init
> >    callback don't contribute to system randomness more than once.  The
> >    weirdness is resolved here by using the randomness each time
> >    hwrng_init() is attempted, irrespective of the existence of the
> >    device's ->init() callback.
> 
> All applied to crypto.  Thanks!

Thanks, Herbert.  I didn't mention it, but pls queue it up for 3.16.


		Amit