From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757561AbaGOEtz (ORCPT ); Tue, 15 Jul 2014 00:49:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56898 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbaGOEtw (ORCPT ); Tue, 15 Jul 2014 00:49:52 -0400 Date: Tue, 15 Jul 2014 10:19:13 +0530 From: Amit Shah To: Herbert Xu Cc: linux-kernel@vger.kernel.org, Virtualization List , Rusty Russell , keescook@chromium.org, jason@lakedaemon.net Subject: Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes Message-ID: <20140715044913.GB26186@grmbl.mre> References: <20140714125006.GA9958@gondor.apana.org.au> <20140715044028.GA26186@grmbl.mre> <20140715044556.GA18469@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140715044556.GA18469@gondor.apana.org.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Tue) 15 Jul 2014 [12:45:56], Herbert Xu wrote: > On Tue, Jul 15, 2014 at 10:10:28AM +0530, Amit Shah wrote: > > On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote: > > > On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote: > > > > v3: > > > > - Kees Cook pointed out a weird side-effect: devices which have > > > > ->init() registered get their randomness added to the system each > > > > time they're switched in, but devices that don't have the init > > > > callback don't contribute to system randomness more than once. The > > > > weirdness is resolved here by using the randomness each time > > > > hwrng_init() is attempted, irrespective of the existence of the > > > > device's ->init() callback. > > > > > > All applied to crypto. Thanks! > > > > Thanks, Herbert. I didn't mention it, but pls queue it up for 3.16. > > Yes that's why it's in crypto as opposed to cryptodev. Ah; thanks! Amit