From: Steven Rostedt <rostedt@goodmis.org>
To: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: fweisbec@gmail.com, mingo@redhat.com, jovi.zhangwei@huawei.com,
namhyung.kim@lge.com, tom.zanussi@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] tracing: let user specify tracing_thresh after selecting function_graph
Date: Tue, 15 Jul 2014 09:04:36 -0400 [thread overview]
Message-ID: <20140715090436.1d660119@gandalf.local.home> (raw)
In-Reply-To: <20140715092719.GB5127@stfomichev-desktop.yandex.net>
On Tue, 15 Jul 2014 13:27:19 +0400
Stanislav Fomichev <stfomichev@yandex-team.ru> wrote:
> Hi Steven,
>
> Did you have some spare time to check why I'm getting triple fault with the
> jump labels inside function tracers? Or will you just pull my another
> patch without them?
No, I don't want the overhead of that check if it isn't needed. You
don't need to put a jump label in there either.
Just create another ftrace_ops function that we can update that does
the check when the function is needed. Look at what happens when
someone sets the set_ftrace_pid file.
-- Steve
next prev parent reply other threads:[~2014-07-15 13:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 17:12 [PATCH] " Stanislav Fomichev
2014-06-03 22:57 ` Steven Rostedt
2014-06-04 13:33 ` [PATCHv2] " Stanislav Fomichev
2014-06-04 19:41 ` Steven Rostedt
2014-06-05 7:38 ` Stanislav Fomichev
2014-07-15 9:27 ` Stanislav Fomichev
2014-07-15 13:04 ` Steven Rostedt [this message]
2014-07-15 15:31 ` [PATCHv3] " Stanislav Fomichev
2014-07-17 18:08 ` Steven Rostedt
2014-07-18 11:17 ` [PATCHv4] " Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715090436.1d660119@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung.kim@lge.com \
--cc=stfomichev@yandex-team.ru \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®