From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements
Date: Tue, 15 Jul 2014 08:07:38 -0700 [thread overview]
Message-ID: <20140715150738.GB19185@kroah.com> (raw)
In-Reply-To: <1405365333-17170-5-git-send-email-peter.senna@gmail.com>
On Mon, Jul 14, 2014 at 09:15:32PM +0200, Peter Senna Tschudin wrote:
> Use tabs instead of spaces in a set of statements and fix lines
> over 80 chars. Reported by checkpatch.
>
> Tested by compilation only.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Cahnges from V3:
> - Splitted the patches by change type
>
> drivers/staging/vt6656/main_usb.c | 44 ++++++++++++++++++++-------------------
> 1 file changed, 23 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 553a8e9..cc0281a 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -382,38 +382,40 @@ static int device_init_registers(struct vnt_private *pDevice)
> /* load vt3266 calibration parameters in EEPROM */
> if (pDevice->byRFType == RF_VT3226D0) {
> if ((pDevice->abyEEPROM[EEP_OFS_MAJOR_VER] == 0x1) &&
> - (pDevice->abyEEPROM[EEP_OFS_MINOR_VER] >= 0x4)) {
> + (pDevice->abyEEPROM[EEP_OFS_MINOR_VER] >= 0x4)) {
Shouldn't this be indented by 1 more space?
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-15 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 19:15 [PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues Peter Senna Tschudin
2014-07-14 19:15 ` [PATCH V4 2/6] staging: vt6556: Remove double parentheses Peter Senna Tschudin
2014-07-14 19:15 ` [PATCH V4 3/6] staging: vt6556: Remove uneeded return statements Peter Senna Tschudin
2014-07-14 19:15 ` [PATCH V4 4/6] staging: vt6556: Remove typedefs Peter Senna Tschudin
2014-07-15 15:06 ` Greg KH
2014-07-15 20:05 ` Peter Senna Tschudin
2014-07-15 23:53 ` Greg KH
2014-07-14 19:15 ` [PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements Peter Senna Tschudin
2014-07-15 15:07 ` Greg KH [this message]
2014-07-14 19:15 ` [PATCH V4 6/6] staging: vt6556: Replace printk by pr_warn Peter Senna Tschudin
2014-07-15 15:06 ` Greg KH
2014-07-15 15:04 ` [PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715150738.GB19185@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®