From: Steven Rostedt <rostedt@goodmis.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] tracing: change apply_subsystem_event_filter() paths to check file->system == dir
Date: Wed, 16 Jul 2014 14:32:19 -0400 [thread overview]
Message-ID: <20140716143219.4fa2b72e@gandalf.local.home> (raw)
In-Reply-To: <20140715184829.GA20516@redhat.com>
On Tue, 15 Jul 2014 20:48:29 +0200
Oleg Nesterov <oleg@redhat.com> wrote:
> filter_free_subsystem_preds(), filter_free_subsystem_filters() and
> replace_system_preds() can simply check file->system->subsystem and
> avoid strcmp(call->class->system).
>
> Better yet, we can pass "struct ftrace_subsystem_dir *dir" instead of
> event_subsystem and just check file->system == dir.
>
> Thanks to Namhyung Kim who pointed out that replace_system_preds() can
> be changed too.
What? No thanks to me for suggesting the file->system == dir idea?
/me pouts like a baby
-- Steve
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
next prev parent reply other threads:[~2014-07-16 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 18:47 [PATCH v2 0/7] tracing: ->filter cleanups Oleg Nesterov
2014-07-15 18:48 ` [PATCH v2 1/7] tracing: kill destroy_preds() and destroy_file_preds() Oleg Nesterov
2014-07-15 18:48 ` [PATCH v2 2/7] tracing: kill destroy_call_preds() Oleg Nesterov
2014-07-15 18:48 ` [PATCH v2 3/7] tracing: kill call_filter_disable() Oleg Nesterov
2014-07-15 18:48 ` [PATCH v2 4/7] tracing/uprobes: kill the dead TRACE_EVENT_FL_USE_CALL_FILTER logic Oleg Nesterov
2014-07-15 18:48 ` [PATCH v2 5/7] tracing: kill ftrace_event_call->files Oleg Nesterov
2014-07-15 18:48 ` [PATCH v2 6/7] tracing: change apply_subsystem_event_filter() paths to check file->system == dir Oleg Nesterov
2014-07-16 18:32 ` Steven Rostedt [this message]
2014-07-16 19:12 ` Oleg Nesterov
2014-07-16 19:59 ` Steven Rostedt
2014-07-15 18:48 ` [PATCH v2 7/7] tracing: kill "filter_string" arg of replace_preds() Oleg Nesterov
2014-07-17 8:05 ` [PATCH v2 0/7] tracing: ->filter cleanups Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716143219.4fa2b72e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®