From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline
Date: Thu, 17 Jul 2014 15:53:46 -0700 [thread overview]
Message-ID: <20140717155346.afadf6243dc6c0ebfda95853@linux-foundation.org> (raw)
In-Reply-To: <20140716213247.GC21290@p183.telecom.by>
On Thu, 17 Jul 2014 00:32:47 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Convert /proc/$PID/cmdline to seq_file interface.
>
> XXX
Unsure what XXX signifies.
> This one must be buggy.
>
> seq_file buffer is adjustable, so userspace can execute itself
> with huge command line (which can be arbitrarily long now), then read 1 byte.
>
> Voila, whole command line now is in kmalloced/vmalloced memory.
>
> Imposing limit is trivial but equally lame to current PAGE_SIZE limit.
Confused. Why send the patch if you don't like it?
Why not go ahead and impose the PAGE_SIZE limit?
next prev parent reply other threads:[~2014-07-17 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 21:32 Alexey Dobriyan
2014-07-17 22:53 ` Andrew Morton [this message]
2014-07-18 20:10 ` Alexey Dobriyan
2014-07-18 20:12 ` [PATCH v2 04/10] proc: convert /proc/$PID/cmdline to seq_file interface Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717155346.afadf6243dc6c0ebfda95853@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®