From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: perex@perex.cz, tiwai@suse.de, lgirdwood@gmail.com,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: arizona: Disable AIF TX/RX before configuring it
Date: Thu, 17 Jul 2014 20:42:15 +0100 [thread overview]
Message-ID: <20140717194215.GH17528@sirena.org.uk> (raw)
In-Reply-To: <20140716121029.GA22222@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
On Wed, Jul 16, 2014 at 01:10:39PM +0100, Richard Fitzgerald wrote:
> If we don't disable the AIF TX/RX then we may fall into a
> situation where the new AIF settings are ignored by the device.
> For example, this problem manifests when switching between
> different sample rates.
So, what this does is momentarily disable the AIF when reconfiguring.
That will glitch any running audio, making me wonder if the driver
shouldn't be returning an error or at least complaining if it has to
reconfigure instead. What's the use case where this might get
triggered?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-17 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 12:10 Richard Fitzgerald
2014-07-17 19:42 ` Mark Brown [this message]
2014-07-21 9:01 ` Richard Fitzgerald
2014-07-21 9:04 ` Takashi Iwai
2014-07-21 10:33 ` Richard Fitzgerald
2014-07-21 16:24 ` Mark Brown
2014-07-22 10:42 ` [PATCH v2] " Richard Fitzgerald
2014-07-22 22:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717194215.GH17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®