From: Sebastian Reichel <sre@kernel.org>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
arnd@arndb.de, carlos.chinea@nokia.com
Subject: Re: [PATCH 1/4] drivers/hsi/controllers/omap_ssi{,_port}.c: fix failure checks
Date: Thu, 17 Jul 2014 22:51:15 +0200 [thread overview]
Message-ID: <20140717205114.GC13832@earth.universe> (raw)
In-Reply-To: <1405605234-13559-1-git-send-email-andrey.krieger.utkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Hi,
On Thu, Jul 17, 2014 at 04:53:54PM +0300, Andrey Utkin wrote:
> 1.
>
> [linux-3.16-rc5/drivers/hsi/controllers/omap_ssi.c:357]: (style) Checking if
> unsigned variable 'gdd_irq' is less than zero.
>
> Source code is
>
> omap_ssi->gdd_irq = platform_get_irq_byname(pd, "gdd_mpu");
> if (omap_ssi->gdd_irq < 0) {
>
> 2.
>
> [linux-3.16-rc5/drivers/hsi/controllers/omap_ssi_port.c:1017]: (style) Checking
> if unsigned variable 'irq' is less than zero.
>
> Source code is
>
> omap_port->irq = platform_get_irq(pd, 0);
> if (omap_port->irq < 0) {
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80441
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
applied to my for-next branch:
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=b74d4954ae6a6799f7ee832bc377795ab506f4b1
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-07-17 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 13:53 Andrey Utkin
2014-07-17 20:51 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717205114.GC13832@earth.universe \
--to=sre@kernel.org \
--cc=andrey.krieger.utkin@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos.chinea@nokia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®