From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian Kent <raven@themaw.net>
Subject: [PATCH 2/5] autofs4: remove a redundant assignment
Date: Fri, 18 Jul 2014 10:48:28 +1000 [thread overview]
Message-ID: <20140718004828.19389.22656.stgit@notabene.brown> (raw)
In-Reply-To: <20140718004353.19389.48104.stgit@notabene.brown>
The variable 'ino' already exists and already
has the correct value. The d_fsdata of a dentry
is never changed after the d_fsdata is instantiated,
so this new assignment cannot be necessary.
It was introduced in
commit b5b801779d59165c4ecf1009009109545bd1f642
autofs4: Add d_manage() dentry operation
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Ian Kent <raven@themaw.net>
---
fs/autofs4/expire.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c
index 394e90b02c5e..a7be57e39be7 100644
--- a/fs/autofs4/expire.c
+++ b/fs/autofs4/expire.c
@@ -333,7 +333,6 @@ struct dentry *autofs4_expire_direct(struct super_block *sb,
if (ino->flags & AUTOFS_INF_PENDING)
goto out;
if (!autofs4_direct_busy(mnt, root, timeout, do_now)) {
- struct autofs_info *ino = autofs4_dentry_ino(root);
ino->flags |= AUTOFS_INF_EXPIRING;
init_completion(&ino->expire_complete);
spin_unlock(&sbi->fs_lock);
next prev parent reply other threads:[~2014-07-18 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 0:48 [PATCH 0/5] clean-up patch for autofs4 NeilBrown
2014-07-18 0:48 ` NeilBrown [this message]
2014-07-18 0:48 ` [PATCH 3/5] autofs4: don't take spinlock when not needed in autofs4_lookup_expiring NeilBrown
2014-07-18 0:48 ` [PATCH 5/5] autofs4: comment typo: remove a a doubled word NeilBrown
2014-07-18 0:48 ` [PATCH 4/5] autofs4: remove some unused inline functions NeilBrown
2014-07-18 0:48 ` [PATCH 1/5] autofs4: remove unused autofs4_ispending() NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718004828.19389.22656.stgit@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=autofs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®