From: Christoph Hellwig <hch@lst.de>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: poma <pomidorabelisima@gmail.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Mailing-List fedora-kernel <kernel@lists.fedoraproject.org>,
Christoph Hellwig <hch@lst.de>,
Paolo Bonzini <pbonzini@redhat.com>,
James Bottomley <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()
Date: Fri, 18 Jul 2014 16:17:47 +0200 [thread overview]
Message-ID: <20140718141747.GA23272@lst.de> (raw)
In-Reply-To: <20140718132104.GK27940@esperanza>
On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote:
> Slab warns, because the name of the cache being created contains spaces.
> The "bad" cache is created by scsi_get_host_cmd_pool. Its name
> (pool->cmd_name) is initialized by scsi_alloc_host_cmd_pool as follows:
>
> pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name);
>
> So, if hostt->name contains spaces, the cache name will also contain
> spaces and we'll get the warning. And hostt->name can contain spaces,
> e.g. virtscsi_host_template_single.name="Virtio SCSI HBA".
Or might not even be present. I'll send a patch to replace it with
->proc_name, which must not contain spaces and is generally shorter
as well.
next prev parent reply other threads:[~2014-07-18 14:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53C8DF7F.5060707@gmail.com>
2014-07-18 10:57 ` poma
2014-07-18 13:21 ` Vladimir Davydov
2014-07-18 14:17 ` Christoph Hellwig [this message]
2014-07-18 20:01 ` poma
2014-07-18 20:07 ` James Bottomley
2014-07-18 20:16 ` poma
2014-07-18 21:32 ` poma
2014-07-19 16:44 ` Christoph Hellwig
2014-07-21 9:39 ` poma
2014-07-21 14:58 ` Christoph Hellwig
2014-07-21 15:38 ` poma
2014-07-26 16:21 ` Christoph Hellwig
2014-07-26 16:44 ` Martin K. Petersen
2014-07-27 8:09 ` Vladimir Davydov
2014-07-28 7:49 ` James Bottomley
2014-07-29 12:26 ` Christoph Hellwig
2014-07-29 23:25 ` poma
2014-07-30 12:21 ` Josh Boyer
2014-07-30 14:52 ` Christoph Hellwig
2014-07-30 15:04 ` James Bottomley
2014-07-30 16:15 ` Christoph Hellwig
2014-07-30 17:22 ` Mike Christie
2014-07-30 17:59 ` Christoph Hellwig
2014-07-31 13:02 ` James Bottomley
2014-07-18 14:20 ` Christoph Lameter
2014-07-18 20:03 ` poma
2014-07-18 21:35 ` poma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718141747.GA23272@lst.de \
--to=hch@lst.de \
--cc=JBottomley@parallels.com \
--cc=cl@linux.com \
--cc=kernel@lists.fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pomidorabelisima@gmail.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome