From: Mark Brown <broonie@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Benoit Cousson <bcousson@baylibre.com>,
Shubhrajyoti D <shubhrajyoti@ti.com>, Charulatha V <charu@ti.com>
Subject: Re: [PATCH] spi: omap2-mcspi: fix blatant abuse of the resource subsystem
Date: Fri, 18 Jul 2014 18:10:35 +0100 [thread overview]
Message-ID: <20140718171035.GQ17528@sirena.org.uk> (raw)
In-Reply-To: <1405683053-14104-1-git-send-email-LW@KARO-electronics.de>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On Fri, Jul 18, 2014 at 01:30:53PM +0200, Lothar Waßmann wrote:
> Aua. This really hurts. I wonder how this could ever be admitted to
> the Linux kernel...
> Further comments suppressed because the would most likely violate the
> CDA.
>
> If someone should not grasp what this patch does, they should consider
> what happens upon unloading/reloading the kernel module.
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
I'm not going to apply this with a commit message such as the above.
Quite aside from the tone the fact that it doesn't describe the issue
is not helpful for review, one of the things done in review is to try to
check that the change has the intended effect.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-18 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 11:30 Lothar Waßmann
2014-07-18 17:10 ` Mark Brown [this message]
2014-07-21 5:51 ` Lothar Waßmann
2014-07-21 12:18 ` Mark Brown
2014-07-21 12:41 ` Lothar Waßmann
2014-07-21 15:44 ` Mark Brown
2016-10-04 9:27 ` Applied "spi: omap2-mcspi: Fix modifying platform resource data" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718171035.GQ17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=LW@KARO-electronics.de \
--cc=bcousson@baylibre.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®