mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Bombe <aeb@debian.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [REGRESSION] Boot hang with 939f04bec printk: enable interrupts before calling console_trylock_for_printk()
Date: Sat, 19 Jul 2014 00:50:05 +0200	[thread overview]
Message-ID: <20140718225005.GA17140@amos.fritz.box> (raw)
In-Reply-To: <20140717083137.GA1649@quack.suse.cz>

On Thu, Jul 17, 2014 at 10:31:37AM +0200, Jan Kara wrote:
> On Wed 16-07-14 23:34:08, Andreas Bombe wrote:
> > On Mon, Jul 14, 2014 at 10:35:27AM +0200, Jan Kara wrote:
> > > On Sun 29-06-14 00:50:50, Andreas Bombe wrote:
> > > > None of the post 3.15 kernel boot for me. They all hang at the GRUB
> > > > screen telling me it loaded and started the kernel, but the kernel
> > > > itself stops before it prints anything (or even replaces the GRUB
> > > > background graphics).
> > > > 
> > > > I bisected it down to 939f04bec1a4ef6ba4370b0f34b01decc844b1b1 "printk:
> > > > enable interrupts before calling console_trylock_for_printk()".
> > > > Reverting that patch on the latest kernel (git 24b414d5a7) allows me to
> > > > boot normally. I fixed the conflict in the revert by leaving in the "if
> > > > (in_sched) return printed_len;".
> > > > 
> > > > I have the "early printk via the EFI framebuffer" option enabled,
> > > > disabling it made no difference however.
> > >   Thanks for report. I've been on vacation so I'm replying with a delay. I
> > > believe this is one of the issues where this patch just uncovers underlying
> > > problem - I belive lockdep tries to report some locking issue in console
> > > driver code (this patch increased lockdep coverage of console driver code)
> > > however we are holding some locks in printk code which make lockdep
> > > deadlock. Can you try running with the attached patch?
> > 
> > EUNABLE
> > 
> > You forgot to attach a patch.
>   Bah, sorry. Attaching now.

I don't see anything in /sys/kernel/debug/tracing/trace_pipe or
.../trace (besides the header) with your patch applied. In case you
meant to test it with the problematic printk change, I also tried with
the revert reverted. That still hangs as before without any error report
to see.

I checked the kernel logs and there is also no lockdep report anywhere.
I get the "trace_printk() being used" notice but nothing else of
interest around there. Though the notice should mean trace_printk() was
used at least once?

  reply	other threads:[~2014-07-18 22:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28 22:50 Andreas Bombe
2014-06-30 20:20 ` Andrew Morton
2014-07-03  0:57   ` Andreas Bombe
2014-07-14  8:35 ` Jan Kara
2014-07-16 21:34   ` Andreas Bombe
2014-07-17  8:31     ` Jan Kara
2014-07-18 22:50       ` Andreas Bombe [this message]
2014-07-21 10:04         ` Jan Kara
2014-07-22 23:29           ` Andreas Bombe
2014-07-23  7:43             ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718225005.GA17140@amos.fritz.box \
    --to=aeb@debian.org \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome