From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: detach rescuer from pool until the last
Date: Fri, 18 Jul 2014 18:51:59 -0400 [thread overview]
Message-ID: <20140718225159.GB5739@htj.dyndns.org> (raw)
In-Reply-To: <1405493811-26203-1-git-send-email-laijs@cn.fujitsu.com>
Hello,
On Wed, Jul 16, 2014 at 02:56:50PM +0800, Lai Jiangshan wrote:
> @@ -2300,11 +2300,6 @@ repeat:
> move_linked_works(work, scheduled, &n);
>
> process_scheduled_works(rescuer);
> - spin_unlock_irq(&pool->lock);
> -
> - worker_detach_from_pool(rescuer, pool);
> -
> - spin_lock_irq(&pool->lock);
>
> /*
> * Put the reference grabbed by send_mayday(). @pool won't
> @@ -2322,8 +2317,11 @@ repeat:
> wake_up_worker(pool);
>
> rescuer->pool = NULL;
> - spin_unlock(&pool->lock);
> - spin_lock(&wq_mayday_lock);
> + spin_unlock_irq(&pool->lock);
> +
> + worker_detach_from_pool(rescuer, pool);
> +
> + spin_lock_irq(&wq_mayday_lock);
Can you please also update the comment above put_pwq() and explain
above detach that @pool will stay around till detach is complete?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-18 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 6:56 Lai Jiangshan
2014-07-18 22:51 ` Tejun Heo [this message]
2014-07-22 5:03 ` [PATCH v2] " Lai Jiangshan
2014-07-22 15:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718225159.GB5739@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®