From: David Miller <davem@davemloft.net>
To: ethan.zhao@oracle.com
Cc: manish.chopra@qlogic.com, sony.chacko@qlogic.com,
rajesh.borundia@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ethan.kernel@gmail.com
Subject: Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()
Date: Sun, 20 Jul 2014 20:58:30 -0700 (PDT) [thread overview]
Message-ID: <20140720.205830.595868255699983537.davem@davemloft.net> (raw)
In-Reply-To: <1405655009-18975-1-git-send-email-ethan.zhao@oracle.com>
From: Ethan Zhao <ethan.zhao@oracle.com>
Date: Fri, 18 Jul 2014 11:43:29 +0800
> netxen driver has implemented netxen_nic_get_ethtool_stats() interface,
> but it doesn't collect stats.rxdropped in driver, so we will get
> different rx_dropped statistic information while using ifconfig and ethtool.
> this patch fills stats.rxdropped field with data from net core
> with dev_get_stats() just as ixgbe driver did for some of its stats.
>
> Tested with last netxen 4.0.82
> Compiled with stable 3.15.6
>
> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
> Tested-by: Sriharsha Yadagudde <sriharsha.devdas@oracle.com>
ethtool stats are _NOT_ the place to duplicate normal netdev stats,
PERIOD.
The only exception is when you maintainer per-queue instaces of these
stats, and want to export that information to the user.
I'm not applying this, sorry.
prev parent reply other threads:[~2014-07-21 3:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 3:43 Ethan Zhao
2014-07-18 3:47 ` Varka Bhadram
2014-07-18 6:05 ` Ethan Zhao
2014-07-18 6:08 ` Varka Bhadram
2014-07-18 18:21 ` Rajesh Borundia
2014-07-19 5:45 ` Ethan Zhao
2014-07-19 10:19 ` Francois Romieu
2014-07-19 11:45 ` Ethan Zhao
2014-07-19 16:28 ` Francois Romieu
2014-07-20 0:43 ` Ethan Zhao
2014-07-20 2:52 ` Ethan Zhao
2014-07-20 18:01 ` Francois Romieu
2014-07-21 1:56 ` Ethan Zhao
2014-07-21 3:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140720.205830.595868255699983537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ethan.kernel@gmail.com \
--cc=ethan.zhao@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®