mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@lisas.de>
To: Wang YanQing <udknight@gmail.com>
Cc: linus.walleij@linaro.org, gregkh@linuxfoundation.org,
	jhovold@gmail.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio:gpio-pl2303: add gpio driver for GPIOs on PL2303
Date: Sun, 20 Jul 2014 22:11:30 +0200	[thread overview]
Message-ID: <20140720201130.GA9380@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20140720000131.GA2158@udknight>

Hi,

> +#include <linux/slab.h>
> +#include <linux/usb.h>
> +#include <linux/gpio.h>



> +	pl2303_gpio_write(&pl2303_gpio->gpio_chip);
> +
> +	ret = gpiochip_add(&pl2303_gpio->gpio_chip);
> +	if (ret < 0) {


AFAICS that stuff is conditional:ed by #ifdef CONFIG_GPIOLIB in
gpio.h (or rather, its internally included asm-generic/gpio.h)

Thus

> +config GPIO_PL2303
> +	tristate "USB Prolific 2303 gpio support"
> +	depends on USB_SERIAL_PL2303
> +	help
> +	  Enable support for GPIOs on USB Prolific 2303
> +	  It support two GPIOs on PL2303HX currently.

quite likely a
	depends on GPIOLIB && ...
is missing here (as is done with several other GPIO support drivers
in the same Kconfig)

Thanks for this nicely functionality-enhancing serial driver addition,

Andreas Mohr

      parent reply	other threads:[~2014-07-20 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20  0:01 Wang YanQing
2014-07-20  0:10 ` Greg KH
2014-07-20 20:11 ` Andreas Mohr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720201130.GA9380@rhlx01.hs-esslingen.de \
    --to=andi@lisas.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhovold@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome