mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Josef Bacik <jbacik@fb.com>
Cc: <linux-kernel@vger.kernel.org>, Darren Hart <darren@dvhart.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] trace-cmd: add trace-record.o to the python shared lib
Date: Mon, 21 Jul 2014 17:01:53 -0400	[thread overview]
Message-ID: <20140721170153.42a0d5d2@gandalf.local.home> (raw)
In-Reply-To: <1405975844-2361-1-git-send-email-jbacik@fb.com>

Cc'd my python gurus.

Acks?

-- Steve


On Mon, 21 Jul 2014 16:50:44 -0400
Josef Bacik <jbacik@fb.com> wrote:

> When trying to use the python library it was giving me an error about not being
> able to resolve tracecmd_stat_cpu.  This is because we weren't linking
> trace-record.o to ctracecmd.so.  Fix this in the makefile and now I can import
> trace-cmd in python properly.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index df5ec72..f6c2875 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -321,7 +321,7 @@ KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) \
>  PEVENT_LIB_OBJS = event-parse.o trace-seq.o parse-filter.o parse-utils.o
>  TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
>  			trace-output.o trace-recorder.o trace-restore.o trace-usage.o \
> -			trace-blk-hack.o kbuffer-parse.o event-plugin.o
> +			trace-blk-hack.o kbuffer-parse.o event-plugin.o trace-record.o
>  
>  PLUGIN_OBJS =
>  PLUGIN_OBJS += plugin_jbd2.o


  reply	other threads:[~2014-07-21 21:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 20:50 Josef Bacik
2014-07-21 21:01 ` Steven Rostedt [this message]
2014-07-22 12:58   ` Johannes Berg
2014-07-30 16:11     ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721170153.42a0d5d2@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=darren@dvhart.com \
    --cc=jbacik@fb.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®