From: Alexander Gordeev <agordeev@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: bitmap tag: fix potential unwakeable sleep in bt_get()
Date: Tue, 22 Jul 2014 10:27:16 +0200 [thread overview]
Message-ID: <20140722082716.GA12370@dhcp-26-207.brq.redhat.com> (raw)
In-Reply-To: <20140721091144.GB2107@dhcp-26-207.brq.redhat.com>
On Mon, Jul 21, 2014 at 11:11:44AM +0200, Alexander Gordeev wrote:
> > My bad, was looking at the wrong sources. What is the race? If the
> > clear and wakeup come in after the prepare_to_wait() but before the
> > io_schedule(), the io_schedule() will be a no-op and it wont
> > actually sleep. Your commit message doesn't mention any particular
> > details.
>
> Let me examine the code.. It was few weeks ago and I can not
> remember what was that. And the changelog does not help :)
Jens,
I can not recall what was my concern. Sorry for the noise.
Thanks!
> > --
> > Jens Axboe
> >
--
Regards,
Alexander Gordeev
agordeev@redhat.com
prev parent reply other threads:[~2014-07-22 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 8:10 Alexander Gordeev
2014-07-21 8:16 ` Jens Axboe
2014-07-21 8:32 ` Alexander Gordeev
2014-07-21 8:34 ` Jens Axboe
2014-07-21 9:11 ` Alexander Gordeev
2014-07-22 8:27 ` Alexander Gordeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722082716.GA12370@dhcp-26-207.brq.redhat.com \
--to=agordeev@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®