From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set_flags()
Date: Tue, 22 Jul 2014 10:38:24 -0400 [thread overview]
Message-ID: <20140722143824.GC13851@htj.dyndns.org> (raw)
In-Reply-To: <1406005330-11864-2-git-send-email-laijs@cn.fujitsu.com>
On Tue, Jul 22, 2014 at 01:02:00PM +0800, Lai Jiangshan wrote:
> worker_set_flags() doesn't necessarily wake next worker and the @wakeup
> can be removed, the caller can use the following conbination instead
> when needed:
>
> worker_set_flags();
> if (need_more_worker(pool))
> wake_up_worker(pool);
>
> It reduces the machine-code and footprint for the process_one_work()
> if worker_set_flags() is really inlined.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied 1-2 to wq/for-3.17 w/ descriptions and comments updated.
Thanks.
--
tejun
prev parent reply other threads:[~2014-07-22 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 10:09 [PATCH 1/2] workqueue: remove unneeded test before wake up next worker Lai Jiangshan
2014-07-16 10:09 ` [PATCH 2/2] workqueue: remove the argument @wakeup from worker_set_flags() Lai Jiangshan
2014-07-18 22:38 ` Tejun Heo
2014-07-18 22:53 ` Tejun Heo
2014-07-18 22:05 ` [PATCH 1/2] workqueue: remove unneeded test before wake up next worker Tejun Heo
2014-07-18 22:53 ` Tejun Heo
2014-07-22 5:01 ` [PATCH 1/2 V2] " Lai Jiangshan
2014-07-22 5:02 ` [PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set_flags() Lai Jiangshan
2014-07-22 14:38 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722143824.GC13851@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®