From: Sebastian Reichel <sre@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Dmitry Artamonow <mad_soft@inbox.ru>
Subject: Re: [PATCH] power: add driver for battery reading on iPaq h3xxx
Date: Wed, 23 Jul 2014 14:54:09 +0200 [thread overview]
Message-ID: <20140723125409.GC18172@earth.universe> (raw)
In-Reply-To: <1405157629-10550-1-git-send-email-linus.walleij@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
Hi Linus,
On Sat, Jul 12, 2014 at 11:33:49AM +0200, Linus Walleij wrote:
> [...]
> +
> +#define BATT_PERIOD 100000 /* 10 seconds in milliseconds */
that's 100 seconds...
> [...]
> +
> +struct micro_battery {
> + struct ipaq_micro *micro;
> + struct workqueue_struct *wq;
> + struct delayed_work update;
> + u8 ac;
> + u8 chemistry;
> + unsigned int voltage;
> + u16 temperature;
> + u8 flag;
> +};
> +
> [...]
> +
> +static struct power_supply micro_battery = {
^^^^^^^^^^^^^
I would prefer to have a name different from the struct defined
above.
> [...]
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-07-23 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 9:33 Linus Walleij
2014-07-22 21:51 ` Linus Walleij
2014-07-23 12:54 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723125409.GC18172@earth.universe \
--to=sre@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mad_soft@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®