mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Benoit Masson <benoitm@perenite.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Benoit Masson <yahoo@perenite.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Subject: Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS
Date: Thu, 24 Jul 2014 10:56:21 -0400	[thread overview]
Message-ID: <20140724145621.GX23220@titan.lakedaemon.net> (raw)
In-Reply-To: <20140724142918.GG28485@lunn.ch>

On Thu, Jul 24, 2014 at 04:29:18PM +0200, Andrew Lunn wrote:
> > The only outstanding point (Arnd?), is that I think it's ok to have the
> > i2c...a0 compatible string in the dts files, but Andrew seems to think
> > otherwise.  Is that still true Andrew?
> 
> Hi Jason
> 
> I can live with i2c...a0 compatible string, but it has minor problems:
> 
> 1) The binding Documentation says not to do it. So we are ignoring our
>    own documentation.

This can be updated.

> 2) It seems likely that at some point the OEM will swap to B1 revision
>    SoCs. The i2c device then does not require this quirk, but we have
>    hard coded in the DT file that it is required. B1 revision would
>    work, but not optimally.

The quirk can go both ways.  eg, we can detect that we *aren't* on an A0
and need to remove the compatible string.

> So i would prefer not to explicitly enable the quirk, but determine at
> run time if the quirk is needed for the SoC revision it is running on.

I agree, but that is Linux-centric.  We need to handle it coherently in
the binding docs for *BSD, bootloaders, etc.

I suggest we update the binding to allow using the compatible string,
and advise that to avoid end-user frustration, implementations should
detect the SoC revision at runtime and either add or remove the
compatible string.

thx,

Jason.

  reply	other threads:[~2014-07-24 14:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 22:35 [PATCH 1/2] Adding Lenovo - Lenovo Group Ltd. to the vendor-prefixes list Benoit Masson
2014-07-23 22:32 ` Andrew Lunn
2014-07-23 22:35 ` [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Benoit Masson
2014-07-23 22:42   ` Andrew Lunn
2014-07-23 22:56     ` Benoit Masson
2014-07-23 22:58       ` Andrew Lunn
     [not found]         ` <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com>
2014-07-23 23:15           ` Jason Cooper
2014-07-24 12:21             ` Gregory CLEMENT
2014-07-24 12:45               ` Jason Cooper
2014-07-24 13:29                 ` Andrew Lunn
     [not found]                 ` <C2E7C8C1-1198-4785-AB9C-C27B5E27A8D4@perenite.com>
2014-07-24 14:07                   ` Jason Cooper
2014-07-24 14:29                     ` Andrew Lunn
2014-07-24 14:56                       ` Jason Cooper [this message]
2014-07-24 12:45 ` [PATCH 1/2] Adding Lenovo - Lenovo Group Ltd. to the vendor-prefixes list Rob Herring
2014-07-28 13:43 ` Jason Cooper
2014-07-23 22:52 [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Benoit Masson
2014-07-23 23:27 ` Jason Cooper
2014-07-23 23:29   ` Andrew Lunn
2014-07-23 23:42     ` Jason Cooper
2014-07-24 12:11       ` Jason Cooper
2014-07-24  4:00 ` Baruch Siach
2014-07-26 23:47 Benoit Masson
2014-07-27  1:52 ` Andrew Lunn
2014-07-28  8:49   ` Arnd Bergmann
2014-07-28 10:50     ` Benoit Masson
2014-07-28 11:02       ` Arnd Bergmann
2014-07-28 11:17         ` Benoit Masson
2014-07-28 11:37           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140724145621.GX23220@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=benoitm@perenite.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@googlemail.com \
    --cc=yahoo@perenite.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®