From: Benjamin LaHaise <bcrl@kvack.org>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: axboe@kernel.dk, akpm@linux-foundation.org, jmoyer@redhat.com,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/4] aio: remove the needless registration of ring file's private_data
Date: Thu, 24 Jul 2014 11:55:46 -0400 [thread overview]
Message-ID: <20140724155546.GB22390@kvack.org> (raw)
In-Reply-To: <1406109834-4414-1-git-send-email-guz.fnst@cn.fujitsu.com>
On Wed, Jul 23, 2014 at 06:03:51PM +0800, Gu Zheng wrote:
> Remove the registration of ring file's private_data, we do not use
> it.
Thanks Gu -- applied to my aio-next tree at
git://git.kvack.org/~bcrl/aio-next.git .
-ben
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/aio.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 1c9c5f0..94546ab 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -192,7 +192,6 @@ static struct file *aio_private_file(struct kioctx *ctx, loff_t nr_pages)
> }
>
> file->f_flags = O_RDWR;
> - file->private_data = ctx;
> return file;
> }
>
> --
> 1.7.7
--
"Thought is the essence of where you are now."
next parent reply other threads:[~2014-07-24 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1406109834-4414-1-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-24 15:55 ` Benjamin LaHaise [this message]
[not found] ` <1406109834-4414-2-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-24 15:55 ` [RESEND PATCH 2/4] aio: use the macro rather than the inline magic number Benjamin LaHaise
[not found] ` <1406109834-4414-3-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-24 15:56 ` [RESEND PATCH 3/4] aio: fix some comments Benjamin LaHaise
[not found] ` <1406109834-4414-4-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-23 13:25 ` [RESEND PATCH 4/4] aio: use iovec array rather than the single one Jeff Moyer
2014-07-24 1:15 ` Gu Zheng
2014-07-24 15:56 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724155546.GB22390@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=guz.fnst@cn.fujitsu.com \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome