From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760227AbaGYLNL (ORCPT <rfc822;w@1wt.eu>);
	Fri, 25 Jul 2014 07:13:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55112 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751848AbaGYLNH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Jul 2014 07:13:07 -0400
Date: Fri, 25 Jul 2014 13:12:30 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] perf tools: Add name field into perf_hpp_fmt
Message-ID: <20140725111230.GA1214@krava.brq.redhat.com>
References: <1406251138-6574-1-git-send-email-namhyung@kernel.org>
 <1406251138-6574-7-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1406251138-6574-7-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 25, 2014 at 10:18:57AM +0900, Namhyung Kim wrote:

SNIP

>  }
>  
> -#define __HPP_WIDTH_FN(_type, _str)					\
> +#define __HPP_WIDTH_FN(_type)						\
>  static int hpp__width_##_type(struct perf_hpp_fmt *fmt,			\
>  			      struct perf_hpp *hpp __maybe_unused,	\
>  			      struct perf_evsel *evsel)			\
> @@ -219,19 +219,19 @@ static int hpp__width_##_type(struct perf_hpp_fmt *fmt,			\
>  	if (symbol_conf.event_group)					\
>  		len = max(len, evsel->nr_members * fmt->len);		\
>  									\
> -	if (len < (int)strlen(_str))					\
> -		len = strlen(_str);					\
> +	if (len < (int)strlen(fmt->name))				\
> +		len = strlen(fmt->name);				\

hum, so with the '_str' string argument missing we dont need this
function to be generated by macro, right? could be one single function
called hpp__width_entry or something like that

>  									\
>  	return len;							\
>  }
>  
> -#define __HPP_HEADER_FN(_type, _str) 					\
> +#define __HPP_HEADER_FN(_type) 						\
>  static int hpp__header_##_type(struct perf_hpp_fmt *fmt,		\
>  			       struct perf_hpp *hpp,			\
>  			       struct perf_evsel *evsel)		\
>  {									\
>  	int len = hpp__width_##_type(fmt, hpp, evsel);			\
> -	return scnprintf(hpp->buf, hpp->size, "%*s", len, _str);	\
> +	return scnprintf(hpp->buf, hpp->size, "%*s", len, fmt->name);	\
>  }
>  

same here ^^^ for hpp__header_##_type


jirka