From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@samsung.com>
Cc: linux-kernel@vger.kernel.org, spk.linux@gmail.com
Subject: Re: [PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable
Date: Mon, 28 Jul 2014 07:54:39 +0100 [thread overview]
Message-ID: <20140728065439.GC5273@lee--X1> (raw)
In-Reply-To: <1405684817-20171-2-git-send-email-sachin.kamat@samsung.com>
On Fri, 18 Jul 2014, Sachin Kamat wrote:
> ‘rx_buf’ is not used in this function.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> drivers/mfd/tps65912-spi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
> index 69a5178bf152..de60ad98bd9f 100644
> --- a/drivers/mfd/tps65912-spi.c
> +++ b/drivers/mfd/tps65912-spi.c
> @@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 addr,
> unsigned long spi_data = 1 << 23 | addr << 15 | *data;
> struct spi_transfer xfer;
> struct spi_message msg;
> - u32 tx_buf, rx_buf;
> + u32 tx_buf;
>
> tx_buf = spi_data;
> - rx_buf = 0;
>
> xfer.tx_buf = &tx_buf;
> xfer.rx_buf = NULL;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-28 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 12:00 [PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code Sachin Kamat
2014-07-18 12:00 ` [PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable Sachin Kamat
2014-07-28 6:54 ` Lee Jones [this message]
2014-07-28 6:54 ` [PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728065439.GC5273@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®