From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbaG1LRs (ORCPT ); Mon, 28 Jul 2014 07:17:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57268 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbaG1LRr (ORCPT ); Mon, 28 Jul 2014 07:17:47 -0400 Date: Mon, 28 Jul 2014 13:17:33 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML Subject: Re: [PATCH 4/7] perf report: Honor column width setting Message-ID: <20140728111733.GB1124@krava.brq.redhat.com> References: <1406251138-6574-1-git-send-email-namhyung@kernel.org> <1406251138-6574-5-git-send-email-namhyung@kernel.org> <20140725111302.GB1214@krava.brq.redhat.com> <87k36yia86.fsf@sejong.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k36yia86.fsf@sejong.aot.lge.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 28, 2014 at 09:43:37AM +0900, Namhyung Kim wrote: > On Fri, 25 Jul 2014 13:13:02 +0200, Jiri Olsa wrote: > > On Fri, Jul 25, 2014 at 10:18:55AM +0900, Namhyung Kim wrote: > >> Set column width and do not change it if user gives -w/--column-widths > >> option. It'll truncate longer symbols than the width if exists. > >> > >> Signed-off-by: Namhyung Kim > >> --- > > > > SNIP > > > >> > >> __HPP_COLOR_PERCENT_FN(overhead, period) > >> @@ -797,8 +798,11 @@ static int hist_browser__show_entry(struct hist_browser *browser, > >> if (fmt->color) { > >> width -= fmt->color(fmt, &hpp, entry); > >> } else { > >> - width -= fmt->entry(fmt, &hpp, entry); > >> + int ret = fmt->entry(fmt, &hpp, entry); > >> + s[ret] = '\0'; > >> slsmg_printf("%s", s); > > > > from quick check it seems like all entry callback functions > > use some sort of snprint which should already handle the string > > length properly.. if not, we should fix that instead, no? > > It was 'symbol' sort entry (_hist_entry__sym_snprintf) which has several > snprint calls in it. So I changed here rather than adding complexity > the print function. I can change it if you want. ;) it'd seem more consistent to me.. Arnaldo? ;-) jirka