mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: himangi774@gmail.com
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH] net: irda: delete double assignment
Date: Tue, 29 Jul 2014 15:47:07 -0700 (PDT)	[thread overview]
Message-ID: <20140729.154707.2014852273209594700.davem@davemloft.net> (raw)
In-Reply-To: <20140728152812.GA3000@himangi-Dell>

From: Himangi Saraogi <himangi774@gmail.com>
Date: Mon, 28 Jul 2014 20:58:12 +0530

> @@ -621,7 +621,6 @@ void irlap_send_rd_frame(struct irlap_cb *self)
>  
>  	frame = (struct rd_frame *)skb_put(tx_skb, 2);
>  
> -	frame->caddr = self->caddr;
>  	frame->caddr = RD_RSP | PF_BIT;
>  

This doesn't look correct to me.

I think both lines should be kept, and the second line should be
changed to assign those bits to frame->control.

This is consistent with other parts of the file that make use of the PF_BIT.

      reply	other threads:[~2014-07-29 22:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 15:28 Himangi Saraogi
2014-07-29 22:47 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729.154707.2014852273209594700.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=himangi774@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®