From: Tobias Klauser <tklauser@distanz.ch>
To: Anil Belur <askb23@gmail.com>
Cc: bjorn@mork.no, silvio.fricke@gmail.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation
Date: Tue, 29 Jul 2014 10:05:38 +0200 [thread overview]
Message-ID: <20140729080538.GA16199@distanz.ch> (raw)
In-Reply-To: <1406534292-22601-1-git-send-email-askb23@gmail.com>
On 2014-07-28 at 09:58:12 +0200, Anil Belur <askb23@gmail.com> wrote:
> From: Anil Belur <askb23@gmail.com>
>
> - private_ioctl() the internally calls copy_{to,from}_user() and does
> not use '__user' while refrencing user space pointers.
> - this patch passes __user annotation as a cast, when the pointer is
> being refernced.
Wouldn't it be better to annotate the data member in struct tagSCmdRequest
with __user instead of introducing all these casts?
next prev parent reply other threads:[~2014-07-29 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 7:58 Anil Belur
2014-07-29 8:05 ` Tobias Klauser [this message]
2014-07-29 9:17 ` Dan Carpenter
2014-07-30 2:34 ` Anil Shashikumar Belur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729080538.GA16199@distanz.ch \
--to=tklauser@distanz.ch \
--cc=askb23@gmail.com \
--cc=bjorn@mork.no \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=silvio.fricke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®