mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tobias Klauser <tklauser@distanz.ch>
To: Seunghun Lee <waydi1@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	Lidza Louina <lidza.louina@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: remove commented code
Date: Tue, 29 Jul 2014 11:18:57 +0200	[thread overview]
Message-ID: <20140729091857.GB16199@distanz.ch> (raw)
In-Reply-To: <1406306941-3053-1-git-send-email-waydi1@gmail.com>

On 2014-07-25 at 18:49:01 +0200, Seunghun Lee <waydi1@gmail.com> wrote:
> This patch removes commented code in dgnc driver.
> 
> CC: Lidza Louina <lidza.louina@gmail.com>
> CC: Mark Hounschell <markh@compro.net>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c   |    5 +-
>  drivers/staging/dgnc/dgnc_trace.c |  123 -------------------------------------
>  drivers/staging/dgnc/dgnc_trace.h |   10 ---
>  drivers/staging/dgnc/dgnc_tty.c   |   18 ------
>  drivers/staging/dgnc/digi.h       |    1 -
>  5 files changed, 1 insertion(+), 156 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 8e265c2..4b65306 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1046,10 +1046,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
>  	 * I believe this is a BUG in this UART.
>  	 * So for now, we will leave the code #ifdef'ed out...
>  	 */

The comment above relates to the deleted code, so it should be updated
accordingly.

> -#if 0
> -	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR),
> -					 &ch->ch_cls_uart->isr_fcr);
> -#endif
> +
>  	udelay(10);
>  }

      reply	other threads:[~2014-07-29  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 16:49 Seunghun Lee
2014-07-29  9:18 ` Tobias Klauser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729091857.GB16199@distanz.ch \
    --to=tklauser@distanz.ch \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=waydi1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®