From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
<patches@opensource.wolfsonmicro.com>, <b02247@freescale.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Nicolin Chen <b42378@freescale.com>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm8962: Let CODEC driver enable and disable its own MCLK
Date: Tue, 29 Jul 2014 18:19:51 +0800 [thread overview]
Message-ID: <20140729101950.GB5495@MrMyself> (raw)
In-Reply-To: <20140729095203.GK17528@sirena.org.uk>
On Tue, Jul 29, 2014 at 10:52:03AM +0100, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 10:55:19AM +0800, Nicolin Chen wrote:
> > On Mon, Jul 28, 2014 at 03:19:43PM -0300, Fabio Estevam wrote:
>
> > > >> + pdata->mclk = devm_clk_get(&i2c->dev, NULL);
>
> > > > This is broken for deferred probe.
>
> > Sorry. I don't get why deferred probe would be broken by this.
> > And I just took a test by adding this:
>
> I don't see the code that actually pays attention to the return value
> from devm_clk_get() - in the main probe function the code just treats
> all errors as a missing MCLK.
Just checked the clk_get() code and got the point.
I will add a check to it and return for EPROBE_DEFER.
Thank you,
Nicolin
prev parent reply other threads:[~2014-07-29 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 11:41 Nicolin Chen
2014-07-28 12:22 ` Mark Brown
2014-07-28 18:19 ` [alsa-devel] " Fabio Estevam
2014-07-29 2:55 ` Nicolin Chen
2014-07-29 9:52 ` Mark Brown
2014-07-29 10:19 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729101950.GB5495@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b02247@freescale.com \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome