From: Guillaume Clement <gclement@baobob.org>
To: Fernando Apesteguia <fernando.apesteguia@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Tobias Klauser <tklauser@distanz.ch>
Subject: Re: [PATCH] Staging: vt6655: staticfy variable
Date: Wed, 30 Jul 2014 21:16:40 +0200 [thread overview]
Message-ID: <20140730191638.GA5493@pleinair.baobob.org> (raw)
Hello,
> Add static to variable.
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> ---
> drivers/staging/vt6655/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c
> b/drivers/staging/vt6655/ioctl.c
> index 65e5933..cc6e47b 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -41,7 +41,7 @@
> static int msglevel = MSG_LEVEL_INFO;
>
> #ifdef WPA_SM_Transtatus
> -SWPAResult wpa_Result;
> +static SWPAResult wpa_Result;
> #endif
This changes breaks the compilation (actually the linking). wpa_Result
is actually used in device_main.c in device_open with the following:
> #ifdef WPA_SM_Transtatus
> extern SWPAResult wpa_Result;
> #endif
next reply other threads:[~2014-07-30 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 19:16 Guillaume Clement [this message]
2014-07-30 21:20 ` Fernando Apesteguía
2014-07-31 0:04 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-07-30 16:51 fernando.apesteguia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730191638.GA5493@pleinair.baobob.org \
--to=gclement@baobob.org \
--cc=devel@driverdev.osuosl.org \
--cc=fernando.apesteguia@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®