From: Tejun Heo <tj@kernel.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Jianyu Zhan <Jianyu.Zhan@emc.com>
Subject: Re: [PATCH RFC] sysfs: fix the race of "parent deleted before child added"
Date: Fri, 1 Aug 2014 08:50:45 -0400 [thread overview]
Message-ID: <20140801125045.GA21624@htj.dyndns.org> (raw)
In-Reply-To: <1406891892-10992-1-git-send-email-nasa4836@gmail.com>
Hello,
On Fri, Aug 01, 2014 at 07:18:12PM +0800, Jianyu Zhan wrote:
> A proper fix for this is to pin the parent kernfs_node on the
> dir_entry creation point (sysfs_create_dir_ns), and to de-pin the parent
> on the dir_entry deletion point(sysfs_remove_dir).
The *only* reason we have the warning at all is because the driver
model wants to enforce that destruction is performed in the proper
order and what you're doing is just circumventing the detection logic.
We might as well just remove it. Please track down why the specific
warning that you saw happened. We wanna learn about them and fix
them.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-08-01 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 11:18 Jianyu Zhan
2014-08-01 12:50 ` Tejun Heo [this message]
2014-08-01 14:31 ` Jianyu Zhan
2014-08-01 15:18 ` Tejun Heo
2014-08-01 15:37 ` Jianyu Zhan
2014-08-01 16:54 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801125045.GA21624@htj.dyndns.org \
--to=tj@kernel.org \
--cc=Jianyu.Zhan@emc.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nasa4836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®