From: David Miller <davem@davemloft.net>
To: himangi774@gmail.com
Cc: luka@openwrt.org, rmk+kernel@arm.linux.org.uk,
david.daney@cavium.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH] netdev: octeon_mgmt: Use devm_ioremap_resource
Date: Mon, 04 Aug 2014 12:38:53 -0700 (PDT) [thread overview]
Message-ID: <20140804.123853.791933051871769418.davem@davemloft.net> (raw)
In-Reply-To: <20140731070653.GA3759@himangi-Dell>
From: Himangi Saraogi <himangi774@gmail.com>
Date: Thu, 31 Jul 2014 12:36:53 +0530
> This patch introduces the use of devm_ioremap_resource instead of
> devm_request_mem_region and devm_ioremap. The error handling on the
> platform_get_resource is done way with. The size and start fields in the
> octeon_mgmt are no longer needed. So they are removed and there
> initialization skipped. Also, error handling is added on the values
> returned by devm_ioremap_resource.
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> Not compile tested.
David Daney provided you with a mechanism by which you could
compile test this change, and then I see no response at all
from you after that.
I'm not applying this until it is at least compile tested.
prev parent reply other threads:[~2014-08-04 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 7:06 Himangi Saraogi
2014-07-31 17:19 ` David Daney
2014-08-04 19:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804.123853.791933051871769418.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=luka@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®