From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130AbaHDWIo (ORCPT ); Mon, 4 Aug 2014 18:08:44 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46560 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbaHDWIn (ORCPT ); Mon, 4 Aug 2014 18:08:43 -0400 Date: Mon, 04 Aug 2014 15:08:42 -0700 (PDT) Message-Id: <20140804.150842.507300261765977637.davem@davemloft.net> To: haiyangz@microsoft.com Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH net-next] hyperv: Increase the buffer length for netvsc_channel_cb() From: David Miller In-Reply-To: <1407180825-21832-1-git-send-email-haiyangz@microsoft.com> References: <1407180825-21832-1-git-send-email-haiyangz@microsoft.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Aug 2014 15:08:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Mon, 4 Aug 2014 12:33:45 -0700 > When the buffer is too small for a packet from VMBus, a bigger buffer will be > allocated in netvsc_channel_cb() and retry reading the packet from VMBus. > Increasing this buffer size will reduce the retry overhead. > > Signed-off-by: Haiyang Zhang > Reviewed-by: Dexuan Cui Now netvsc_device is significantly larger than a page, you should probably therefore allocate netvsc_device->cb_buffer indirectly instead of inlining it into the structure.