From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752703AbaHDNIO (ORCPT ); Mon, 4 Aug 2014 09:08:14 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60338 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752239AbaHDNIN (ORCPT ); Mon, 4 Aug 2014 09:08:13 -0400 Date: Mon, 4 Aug 2014 15:08:11 +0200 From: Pavel Machek To: Takashi Iwai Cc: "Lee, Chun-Yi" , "Rafael J. Wysocki" , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" Subject: Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved region Message-ID: <20140804130810.GA23098@amd.pavel.ucw.cz> References: <1407148396-21405-1-git-send-email-jlee@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + > > + list_for_each_entry(region, &nosave_regions, list) { > > + if (pfn >= region->start_pfn && pfn < region->end_pfn) { > > + pr_err("PM: %#010llx in e820 nosave regsion: " And while looking at it, this should probably be spelled "region". ...plus maybe past part of changelog here into the comment? Otherwise looks good to me, Acked-by: Pavel Machek Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html